[Android SDK] Remove ShakeNetworkInteceptor
closed
R
Richárd Radics
Checking network reachability must not be the SDK's responsibility but the application's.
On the Android platform, we received many reports that the application tells the user that it does not have an internet connection, (but of course, it has, because they can report the Shakebugs log) and we checked that these errors are coming from the ShakeNetworkInterceptor. Please remove the network checking code from the SDK and let us (the application developers) handle the internet connection availability.
Also, this network checking in the SDK slowsdown the communication, because you ping google.com if I am not mistaken...
Thanks in advance!
Log In
Mislav Stanic
closed
Mislav Stanic
under review
Mislav Stanic
Richárd Radics It looks like this is not Shake issue, in the stack trace this message is visible: Unable to resolve host "ertbe.go.bkk.hu" - it looks like your servers were out of reach for this user.
This is the case that should be handled in your code, Shake is just intercepting requests(reason why you see it in stack trace) and leaving error handling to the developers.
Shake also supports offline mode, so if user encounters internet connection problem his report is stored locally and then resent later when internet connection is back. So reported ticket is not a proof of available internet connection.
Mislav Stanic
in progress
Mislav Stanic
under review
R
Richárd Radics
This issue is still present.
Tabita Zafar
Richárd Radics: Hey Richard, we appreciate you sending this screenshot too - thanks for leaving this request. Our QA team will update this bug request when any progress is made with it.
R
Richárd Radics
Do you have any update on this? We still receive "fake" internet connectivity issues by this ShakeNetworkInterceptor. Thanks in advance!
Tabita Zafar
Hi Richárd, thanks for your suggestion. I'll talk to one of our Android devs and get back to you here.